Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Add cas operation for apc adapter #4844

Closed
wants to merge 3 commits into from
Closed

Conversation

prolic
Copy link
Contributor

@prolic prolic commented Jul 17, 2013

No description provided.

@weierophinney
Copy link
Member

Please add a unit test, if possible.

@prolic
Copy link
Contributor Author

prolic commented Jul 19, 2013

How to do that without concurrent threads?

@weierophinney
Copy link
Member

@prolic Good point. :) Merging!

weierophinney added a commit that referenced this pull request Jul 19, 2013
Add cas operation for apc adapter
weierophinney added a commit that referenced this pull request Jul 19, 2013
@ghost ghost assigned weierophinney Jul 19, 2013
@weierophinney
Copy link
Member

Merged to develop for release with 2.3.0, as it's a feature addition.

@marc-mabe
Copy link
Member

This breaks the test. apc_cas allows only integer values but we allow all values :(
@Ocramius It's a bit late to revert - should I open a new issue? I'm currently not sure how to solve it.

@Ocramius
Copy link
Member

@marc-mabe you could open a pull request with a failing test case...

@marc-mabe
Copy link
Member

The test's are currently failing. Currently APC no enabled on travis - I'm working on a solution to enable more tests for travis.

https://travis-ci.org/marc-mabe/zf2/builds/43599825
WIP -> This one is using APCu as APC is not available by default on travis since PHP-5.5

@Ocramius
Copy link
Member

@marc-mabe would throwing an exception if ! is_int() be a good idea here?

@marc-mabe
Copy link
Member

@Ocramius I don't think so because other adapter accept it and it's not possible to check before.

weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
@prolic prolic deleted the apc_cas branch September 7, 2015 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants