Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

ArrayObject::offsetExists - Fix check on offsetExists #4852

Closed
wants to merge 1 commit into from
Closed

ArrayObject::offsetExists - Fix check on offsetExists #4852

wants to merge 1 commit into from

Conversation

mwillbanks
Copy link
Contributor

Fix for issue #4832 where we checked isset vs. array_key_exists.

@weierophinney
Copy link
Member

Looks like we need to use version sniffing to determine whether to do array_key_exists or isset?

@mwillbanks
Copy link
Contributor Author

negative; it's actually far worse than that... the contract in arrayobject when we turn it to references is what starts to cause the issue. i'm going to dig a bit deeper when i have some more time tomorrow :)

@weierophinney
Copy link
Member

@mwillbanks Any ideas on how to proceed on this? If this approach won't work, should I close this PR?

@mwillbanks
Copy link
Contributor Author

@weierophinney attempted about 3 or 4 ways to resolve this. The closest I was able to get was turning the metadata into an arrayobject but that caused other tests to fail along with the request access time not to come through in the tests. I think the only real way to resolve this is to remove arrayobject completely from session.

@mwillbanks mwillbanks closed this Aug 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants