This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[suggest] Ignore methods without parameters from aware interfaces #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tux-rampage the idea seems ok - just wondering why there would be aware interfaces without params, but that's another problem... |
|
@Ocramius I'm wondering about this, too. But it doesn't bother me much. Some define the getter as well as the setter. This is a design/philosophy discussion, IMHO not worth debating to much about it. We should give ZF2 consumers this flexibility, no matter if it makes sense to a group of people or not. I guess it doesn't hurt anyone. |
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com) | ||
| * @license http://framework.zend.com/license/new-bsd New BSD License | ||
| * @package Zend_Di |
|
@tux-rampage incorporate the feedback, and I'll review for merge. |
Changed count() check as requested by @weierophinney
|
@weierophinney I changed the code as requested. |
|
@tux-rampage Because in this context, we could have a situation of testing |
weierophinney
added a commit
that referenced
this pull request
Aug 28, 2013
[suggest] Ignore methods without parameters from aware interfaces
ghost
assigned
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…di-fixes [suggest] Ignore methods without parameters from aware interfaces
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
- EOF markers
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some aware interfaces in ZF2 define setters which do not expect any parameter.
These setters are not thought to be called by the dependency injector.
It doesn't make sense anyway to process interface methods from aware interfaces that doesn't have parameters. Even worse: Di could call a method that it should not invoke.