This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Mime\Message: createFromString: really ignore unknown headers #4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
Mime\Message: createFromString: really ignore unknown headers
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
|
Merged to develop for release with 2.3.0. |
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
Mime\Message: createFromString: really ignore unknown headers
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
- indentation
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing that createFromString throws an exception that can't be ignored on such a small detail as an unknown header, especially given that unknown headers can be quite popular. For example, an
X-Attachment-Idheader.It is more confusing that the exception claims to ignore the unknown header, while, of course, it's an exception.
So it doesn't ignore it.