This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added separator to model in renderPartial function #5080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add unit tests for this new feature. |
Changed ModuleManager so I can use statements in application.config.php file like: return array( 'Application', $env=='dev' ? 'ZendDeveloperTools' : null ) Null modules are silently ignored.
| @@ -78,6 +78,7 @@ public function onLoadModules() | |||
| } | |||
|
|
|||
| foreach ($this->getModules() as $moduleName => $module) { | |||
| if ($module == null) continue; | |||
There was a problem hiding this comment.
open bracket '{' after conditinal if, see psr-2 : https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
Changed source to conform to Zend coding standards
| $this->assertInstanceOf('SomeModule\Module', $loadedModules['SomeModule']); | ||
| $this->assertSame(count($loadedModules), 1); | ||
| } | ||
|
|
There was a problem hiding this comment.
What do the module manager commits have to do with this? Please remove.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
Added separator to model in renderPartial function
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
- outside stated scope of issue/pull request.
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
|
Merged to develop for release with 2.3.0; removed all ModuleManager-related commits, as they were not in scope with the stated purpose of the pull request. @serpent7776 -- in the future, please create new branches per feature/bugfix, as stated in the contributing guidelines. |
|
👎 Use in your partial script: $this->navigation()->breadcrumbs()->getSeparator(); |
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…master Added separator to model in renderPartial function
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
- outside stated scope of issue/pull request.
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…master Added separator to model in renderPartial function
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
- EOF marker
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.