This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update label view helper to have html escape by default #5101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replicates the
FormRow
view helper logic, which escapes theElement
label
property by default and takes advantage of the newdisable_html_escape
labelOptions
property added in #4677 to toggle the escape off when needed.This may look like a minor BC break, because anyone who used
FormLabel
helper rather thanFormRow
will now have unexpected escaping, but since the overall policy of ZF2 is 'secure by default' I would rather consider this a minor security fix.