This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/4879 #5108
Closed
Hotfix/4879 #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weierophinney Apparently we can only have multiple interfaces declaring the same method as of PHP 5.3.9 – how are we going to tackle this? |
|
By the way, what I noticed while going through this. The entire idea of creating the ValidatorTranslatorInterface was going to get rid of a direct dependency on Zend\I18n. since the Zend\Mvc\Translator uses stuff from Zend\I18n though, we still have that dependency indirectly, which renders the ValidatorTranslatorInterface obsolete. |
ghost
assigned
|
Thinking about it, this problem can be easily solved by decorating the translator, instead of extending, what do you think, @weierophinney ? |
| @@ -0,0 +1 @@ | |||
| compress me | |||
There was a problem hiding this comment.
added by the tests accidentally?
|
|
||
| if (!isset($config['translator'])) { | ||
| return new DummyTranslator(); | ||
| } |
There was a problem hiding this comment.
We should likely do this for the MvcTranslator service, too.
There was a problem hiding this comment.
NM, this is the MvcTranslator service factory.
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
- should not have been committed
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
|
Merged to develop for release with 2.3.0. |
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Nov 5, 2013
Reverts PR zendframework#5108 This reverts commit 5017af8, reversing changes made to c23c250. The reason this is being reverted is because the solution does not work on 5.3.3; in fact, it will only work starting with version 5.3.9. Until we can either up the minimum required PHP version or come up with an alternate approach, this changeset cannot be included in a release.
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Nov 5, 2013
- Originally included in merge for zendframework#5108
weierophinney
added a commit
that referenced
this pull request
Nov 5, 2013
Reverts #5108 (hopefully temporarily)
|
Re-opening, as the current situation leads to a broken develop branch, unless we up the PHP version. Looking into an alternate solution with @DASPRiD. |
|
Fixed with #5406 |
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
…ix/4879 Hotfix/4879
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
Reverts PR zendframework/zendframework#5108 This reverts commit 5017af832b75d2bdf50f5ca26a8fb3c76782d9cd, reversing changes made to c23c25099512244bb10773558310d5b6ec4de075. The reason this is being reverted is because the solution does not work on 5.3.3; in fact, it will only work starting with version 5.3.9. Until we can either up the minimum required PHP version or come up with an alternate approach, this changeset cannot be included in a release.
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
Reverts zendframework/zendframework#5108 (hopefully temporarily)
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…ix/4879 Hotfix/4879
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Reverts PR zendframework/zendframework#5108 This reverts commit 5017af832b75d2bdf50f5ca26a8fb3c76782d9cd, reversing changes made to c23c25099512244bb10773558310d5b6ec4de075. The reason this is being reverted is because the solution does not work on 5.3.3; in fact, it will only work starting with version 5.3.9. Until we can either up the minimum required PHP version or come up with an alternate approach, this changeset cannot be included in a release.
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Reverts zendframework/zendframework#5108 (hopefully temporarily)
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…ix/4879 Hotfix/4879
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
- should not have been committed
weierophinney
added a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
…ix/4879 Hotfix/4879
weierophinney
added a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
Reverts PR zendframework/zendframework#5108 This reverts commit 5017af832b75d2bdf50f5ca26a8fb3c76782d9cd, reversing changes made to c23c25099512244bb10773558310d5b6ec4de075. The reason this is being reverted is because the solution does not work on 5.3.3; in fact, it will only work starting with version 5.3.9. Until we can either up the minimum required PHP version or come up with an alternate approach, this changeset cannot be included in a release.
weierophinney
added a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
Reverts zendframework/zendframework#5108 (hopefully temporarily)
weierophinney
added a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ix/4879 Hotfix/4879
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Reverts PR zendframework/zendframework#5108 This reverts commit 5017af832b75d2bdf50f5ca26a8fb3c76782d9cd, reversing changes made to c23c25099512244bb10773558310d5b6ec4de075. The reason this is being reverted is because the solution does not work on 5.3.3; in fact, it will only work starting with version 5.3.9. Until we can either up the minimum required PHP version or come up with an alternate approach, this changeset cannot be included in a release.
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
- Originally included in merge for zendframework/zendframework#5108
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Reverts zendframework/zendframework#5108 (hopefully temporarily)
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #4879. It introduces a dummy translator, which is used in case the user did not configure any translator. It also adds a general TranslatorInterface to be typehinted against in our internal code. This should not affect any user-code and thus be BC-safe.