Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix for CamelCase filter when string contains multiple uppercase letters and Unicode is off #5183

Closed
wants to merge 3 commits into from

Conversation

xoob
Copy link
Contributor

@xoob xoob commented Sep 27, 2013

Zend\Filter\Word\CamelCaseToSeparator fails with strings containing camel case, non-word chars and multiple uppercase letters. This only happens when PCRE was compiled without Unicode support.

TheseAre_SOME_CamelCASEDWords
StringUtils::hasPcreUnicodeSupport() == true These_Are_SOME_Camel_CASED_Words
StringUtils::hasPcreUnicodeSupport() == false These_Are_SOM_E_Camel_CASED_Words

Unit test and fix attached to this PR.

* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
* @package Zend_Filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove @Package ^^, we should avoid new created @Package @category and @subcategory docblock

@xoob
Copy link
Contributor Author

xoob commented Oct 1, 2013

@samsonasik Removed!

@ghost ghost assigned weierophinney Oct 23, 2013
weierophinney added a commit that referenced this pull request Oct 23, 2013
Fix for CamelCase filter when string contains multiple uppercase letters and Unicode is off
weierophinney added a commit that referenced this pull request Oct 23, 2013
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
…camelcase

Fix for CamelCase filter when string contains multiple uppercase letters and Unicode is off
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants