-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Minor bugfix: Added missing composer dependency (ServiceManager) to Math package #5186
Minor bugfix: Added missing composer dependency (ServiceManager) to Math package #5186
Conversation
I think it should be on 'suggest' dependency. We still can use Zend\Math\BigInteger\Adapter\Bcmath directly. |
I agree, that you could use I would rather add Btw: |
ok, so it up to the zf maintainer to agree or not :). btw, i think 'component' is the better word than 'module' :D |
@samsonasik Thanks you for the critics about this issue. A second opinion is always good. btw: I changed the title from 'module' to 'package' due the naming taken from here. |
@dol I agree with @samsonasik here -- this is a suggested dependency, not a required dependency, as you can use selected functionality from the component without the ServiceManager package installed. While I understand that the examples in the doc will not work without the SM, the documentation also typically assumes you've installed the entire framework. Change the package to a suggestion, and add in the string "if using the BigInteger::factory functionality". I'd also add "ext-bcmath" and "ext-gmp" as suggestions. |
…dency Minor bugfix: Added missing composer dependency (ServiceManager) to Math package
- Moved servicemanager to suggested dependency - Added ext-bcmath and ext-gmp as suggested dependencies
Forward port #5186 Conflicts: library/Zend/Math/composer.json
…issing-servicemanager-dependency Minor bugfix: Added missing composer dependency (ServiceManager) to Math package
- Moved servicemanager to suggested dependency - Added ext-bcmath and ext-gmp as suggested dependencies
Forward port zendframework/zendframework#5186 Conflicts: library/Zend/Math/composer.json
The Zend\Math package uses the ServiceManager. But the composer.json requirements don't define this dependency.
This PR fixes this issue.