This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
increase consistency : call $this->events, $this->event, $this->response, and $this->request directly at Zend\Mvc\Application.php #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Zend\Mvc\Application.php make consistent with https://github.com/zendframework/zf2/blob/master/library/Zend/Mvc/Application.php#L139
ghost
assigned 
|
I think using getters are better too. |
|
Indeed, this PR only make consistency with other property direct access in the same class. @turrsis You can send a PR with your proposal |
|
@Maks3w @weierophinney I think it should be marked as milestone 2.3.0 instead of 2.2.5 since it only merged into develop :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make consistent with https://github.com/zendframework/zf2/blob/master/library/Zend/Mvc/Application.phpp#L138-L139