This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
change self:: with static:: in call-ing static property/method #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis failure is not related to this PR. |
| @@ -78,11 +78,11 @@ public static function compareVersion($version) | |||
| */ | |||
| public static function getLatest($service = self::VERSION_SERVICE_ZEND, Http\Client $httpClient = null) | |||
| { | |||
| if (null !== self::$latestVersion) { | |||
There was a problem hiding this comment.
Since this class is marked as final, changing self to static makes no sense. :) (I'll revert these on merge.)
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
change self:: with static:: in call-ing static property/method
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
- Since the class is final, LSB can never be invoked.
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
ghost
assigned
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…ix/self-to-static change self:: with static:: in call-ing static property/method
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…ix/self-to-static change self:: with static:: in call-ing static property/method
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of this change is part of #5136 that I forgot to comment about changing self:: to static:: when calling static property/method that merged to develop branch. So I proposed it to be pointed to develop