Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Issue 3104: Form\Element "x-..." attributes #5424

Closed
wants to merge 2 commits into from
Closed

Issue 3104: Form\Element "x-..." attributes #5424

wants to merge 2 commits into from

Conversation

ThaDafinser
Copy link
Contributor

Treat x- attributes like data- attributes

#3104

weierophinney added a commit that referenced this pull request Nov 6, 2013
Issue 3104: Form\Element "x-..." attributes
weierophinney added a commit that referenced this pull request Nov 6, 2013
@ghost ghost assigned weierophinney Nov 6, 2013
@grizzm0
Copy link
Contributor

grizzm0 commented Nov 6, 2013

So far we've never accepted any PRs that would make it possible to render invalid HTML. Should we really start doing that now? We've already said no to the ng- prefix (sure, data-ng works aswell so it doesn't mater).

ping @weierophinney

@weierophinney
Copy link
Member

@grizzm0 The problem is that different JS libraries have standardized on different prefixes. I honestly would like to add ng-* to the mix at this time as well; I think limiting to strict, while an interesting goal, limits (pun intended) the use cases tremendously at this time. (Yes, I've changed my position over time.)

@grizzm0
Copy link
Contributor

grizzm0 commented Nov 6, 2013

@weierophinney Well, ng-* and other PRs were declined in the past as they would be generate invalid HTML. In the AngularJS case it wasn't a problem as they internally translate all data-ng-* to ng-*. The x- prefix is for experimental attributes. Imho we shouldn't promote the use of non-standard or experimental attributes. If a developer would like to use any of them they should extend the base class to allow the rendering of invalid HTML if you ask me.

@ThaDafinser
Copy link
Contributor Author

@grizzm0 i think we definetly do not promote those attributes. But with the growing use of such attributes, it's absolutely necessary, that such attributes are allowed.

The only thing what came up in my mind is, that we could make an option for "strict standard" rendering or render just every attribute?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants