Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Db\Adapter\Driver\PdoResult::current patch #5457

Merged
merged 3 commits into from
Nov 19, 2013
Merged

Zend\Db\Adapter\Driver\PdoResult::current patch #5457

merged 3 commits into from
Nov 19, 2013

Conversation

ChrisSchreiber
Copy link
Contributor

in response to issue #5454

…sts current() returns consistent results

Zend\Db\Adapter\Driver\Pdo\Result::current() fix to prevent calling resource::fetch() on multiple calls

Patch for
@@ -117,6 +117,7 @@ public function current()
}

$this->currentData = $this->resource->fetch(\PDO::FETCH_ASSOC);
$this->currentComplete = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the indentation with above

@@ -0,0 +1,21 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include license :

/**
 * Zend Framework (http://framework.zend.com/)
 *
 * @link      http://github.com/zendframework/zf2 for the canonical source repository
 * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
 * @license   http://framework.zend.com/license/new-bsd New BSD License
 */

here

ralphschindler pushed a commit that referenced this pull request Nov 19, 2013
Merge branch 'zf5454' of git://github.com/ChrisSchreiber/zf2 into ChrisSchreiber-zf5454

* 'zf5454' of git://github.com/ChrisSchreiber/zf2:
  Add license and comments
  fix formatting
  Unit test ZendTest\Db\Adapter\Driver\Pdo\ResultTest::testCurrent() tests current() returns consistent results
ralphschindler pushed a commit that referenced this pull request Nov 19, 2013
Merge branch 'ChrisSchreiber-zf5454'

* ChrisSchreiber-zf5454:
  Removed unnecessary whitespace in Pdo\Resultphp
  Add license and comments
  fix formatting
  Unit test ZendTest\Db\Adapter\Driver\Pdo\ResultTest::testCurrent() tests current() returns consistent results
@ralphschindler ralphschindler merged commit 8522ba6 into zendframework:master Nov 19, 2013
ralphschindler pushed a commit that referenced this pull request Nov 19, 2013
Merge branch 'ChrisSchreiber-zf5454' into develop

* ChrisSchreiber-zf5454:
  Removed unnecessary whitespace in Pdo\Resultphp
  Add license and comments
  fix formatting
  Unit test ZendTest\Db\Adapter\Driver\Pdo\ResultTest::testCurrent() tests current() returns consistent results
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants