This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Validator] Refactor Date #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| $type = gettype($param); | ||
| if (!in_array($type, array('string', 'integer', 'array'))) { | ||
| if ($addErrors) $this->error(self::INVALID); |
There was a problem hiding this comment.
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2013
[Validator] Refactor Date
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2013
- Added blocks where necessary - Conditional structures - constant docblocks
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2013
ghost
assigned
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…or-Date-Validator [Validator] Refactor Date
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
- Added blocks where necessary - Conditional structures - constant docblocks
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Datevalidator convertsstring,array, andintvalues intoDateTimeinstances, or tries to, as part of the validation process. But,DateStepalso uses a conversion process for helper dates. So, the conversion process was synchronized withDateand refactored out into separate methods to allow extending classes to reuse the functionality and to reduce the complexity of the validation method.