-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
using php-cs-fixer
@samsonasik There are test failures in all PHP versions at this point; it looks like the script removed code from the |
@weierophinney fixed ;) |
@samsonasik Please add the necessary changes to the Travis script for automatize this. https://github.com/zendframework/zf2/blob/master/bin/check-cs.sh |
@Maks3w done, I have updated bin/check-cs.sh , and I added exclude tests/ZendTest/Code at tests/.php_cs for checking because of some use statements are necessary as @weierophinney said. |
btw, I curious when adding exclude tests/ZendTest/Code at tests/.php_cs is causing ZendTest/Code is not tested anymore for other case ( trailing_space, function_declaration, etc), I will test it to add failure test on it. |
@weierophinney @Maks3w I have tested excluding tests/ZendTest/Code at tests/.php_cs but it cause that folder not tested anymore for other cases ( trailing_spaces, etc). So, I propose to only check --fixers=unused_use only for library folder, how ? |
IDEs also make use of the use statements in doc blocks. Make sure that the removed aliases were not used in these. |
@DASPRiD I already check that, all aliases for unused use is not used at docblock. Let me know if I missed something, thanks. |
I'll review this manually sortly. |
I just realized that php-cs-fixer support removing unused use statement ^^