Zend db nested transactions #5505
Conversation
| protected $connectionParameters = array(); | ||
|
|
||
| /** | ||
| * @var boolean |
There was a problem hiding this comment.
use
@var bool
for consistency
|
you should only change the change that related with the PR. |
|
How well are nested transactions supported across all of our "officially supported" database platforms? |
|
Some time ago Mysql didn't support it. From the looks of it it may have changed though since 5.5. I've implemented something similar long time ago focused at Mysql<5.5 that implements the same behavior using savepoints: https://github.com/Freeaqingme/FreakLib/blob/master/library/Freak/Db/Adapter/Pdo/Mysql.php |
|
What about the rest? |
|
@ralphschindler Can you mark the milestone please? |
Bump develop branch to 2.4.0dev
2.3.0 readiness Conflicts: README.md library/Zend/Version/Version.php
Bumped master to development release Conflicts: README.md library/Zend/Version/Version.php
Update composer branch aliases
|
@corentin-larose @weierophinney PDO::inTransaction and what if a transation query was invoked directly or something special that closes an open transation like http://dev.mysql.com/doc/refman/5.0/en/implicit-commit.html? |
|
Indeed. |
|
@corentin-larose I would try to focus on the first 80% of use cases, rather than trying to cover all 100% of possible use cases. We could of course always add a warning in the docs stating that if you circumvent Zend\Db in one of several ways, things may/will break. |
|
This has been manually merged into Thanks! |
…structor argument instead of `DbSelect#setSelectCount()`
…property assignments
…for DB2/Firebird compat
…up logic), assuming 4th constructor argument instead of `DbSelect#setSelectCount()`
…stead of additional setter
…onstant use over magic constant: see zendframework/zendframework#5505 for reference
This PR relies on #5001. The goal of this PR is to allow nested db transactions, for instance when tou batch a low level method.