This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix graphme_substr for PHP >= 5.4.18 or >=5.5.1 #5575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due the changes introduced in the intl extension for fix #62759 now the third argument returns an empty string if is null or 0 Open bug #66219 due the BC break introduced in the previous change.
|
Please add a test for the intl wrapper and write a comment containing the minimal PHP version fixed - so if we bump up the required version we can better find such hacks to remove. |
|
@marc-mabe This PR fix the issue with Zend\Validator test run. Also there is no reason for raise the minimum version. This is a new bug introduced in the mentioned versions. |
| @@ -428,6 +428,10 @@ public function testIssnWithMod0() | |||
| */ | |||
| public function testCODE128() | |||
| { | |||
| if (!extension_loaded('iconv')) { | |||
| $this->markTestSkipped('Missing ext/intl'); | |||
There was a problem hiding this comment.
$this->markTestSkipped('Missing ext/iconv'); ?
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Dec 5, 2013
Fix graphme_substr for PHP >= 5.4.18 or >=5.5.1
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…x/php-62759 Fix graphme_substr for PHP >= 5.4.18 or >=5.5.1
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…x/php-62759 Fix graphme_substr for PHP >= 5.4.18 or >=5.5.1
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
- s/intl/iconv/
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due the changes introduced in the intl extension for fix #62759 now the third argument returns an empty string if is null or 0
Open issue #66219 due the new bug introduced in the previous change.
This fix the issue when
$lengthargument is null but not when is0