This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
More lenient db detection in Logger abstract factory #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not check on the writer name, only the presence, type, and availability of the "db" option value. See zendframework#5254 (comment)
ralphschindler
pushed a commit
that referenced
this pull request
Dec 5, 2013
Merge branch 'weierophinney-hotfix/5254-improvement' * weierophinney-hotfix/5254-improvement: Improvement to #5254
ralphschindler
pushed a commit
that referenced
this pull request
Dec 5, 2013
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Merge branch 'weierophinney-hotfix/5254-improvement' * weierophinney-hotfix/5254-improvement: Improvement to zendframework/zendframework#5254
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Merge branch 'weierophinney-hotfix/5254-improvement' into develop * weierophinney-hotfix/5254-improvement: Improvement to zendframework/zendframework#5254
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #5254 was too strict in that it checked for a very specific writer name, when it should only be checking the "db" options key. This PR modifies the behavior of the logger abstract factory to do that.