This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed issue with Math\Rand::getInteger() on ranges close to PHP_INT_MAX #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| do { | ||
| $rnd = hexdec(bin2hex(self::getBytes($bytes, $strong))); | ||
| $rnd = $rnd & $filter; | ||
| $rnd = hexdec(bin2hex(self::getBytes($bytes, $strong))); |
There was a problem hiding this comment.
use static::getBytes instead of self::getBytes
|
@samsonasik @ezimuel PTAL |
|
Is it normal I've changed the test for assert $values to be greater than 0 |
|
Ok, I see what is happenning. $values probably has a value which produce a int overflow as result of operate with big numbers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When min - max range is close or equal to
PHP_INT_MAXlog()produces number of bitsequal to machine size integer. So
$filter = (int) ((1 << $bits) - 1);evaluates to zero.In this case
getInteger(0, PHP_INT_MAX)returns only zeros.PR includes correct bit calculation and test