Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Acl assertions enhancement #5628

Merged

Conversation

gauthier
Copy link
Contributor

AssertionAggregate allows aggregating multiple assertion to be associated with one ACL rule. This has been done without modifying a single file of existing code.

AssertionManager is a simple Plugin Manager allowing to declare Acl asseertions as services. It can be used by AssertionAggregate to add assertions by passing their service name. It could also by used by the Acl component itself, and should be declared as a default service, so that it could rely on Config service to get intialized, but those features would need to alter existing code and I didn't want to do that at this time.

Maks3w and others added 2 commits December 16, 2013 04:03
AssertionAggregate allows aggregating multiple assertion to be associated with one ACL rule. This has been done without modifying a single file of existing code.

AssertionManager is a simple Plugin Manager allowing to declare Acl asseertions as services. It can be used by AssertionAggregate to add assertions by passing their service name. It could also by used by the Acl component itself, and should be declared as a default service, so that it could rely on Config service to get intialized, but those features would need to alter existing code and I didn't want to do that at this time.
* @param AssertionInterface|string $assertion
* if string, must match a AssertionManager declared service (checked later)
*
* @return \Zend\Permissions\Acl\Assertion\AssertionAggregate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return self

*
* @var
*
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either remove the docblock, or make it useful. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm... looks like this was a "temporary" comment to ease Code Insight or something like this - sorry :) I just removed it.

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014
@weierophinney
Copy link
Member

Looks great!

weierophinney added a commit that referenced this pull request Mar 4, 2014
weierophinney added a commit that referenced this pull request Mar 4, 2014
- trailing whitespace
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney weierophinney merged commit 17c3127 into zendframework:develop Mar 4, 2014
@weierophinney weierophinney self-assigned this Mar 4, 2014
weierophinney added a commit to zendframework/zend-permissions-acl that referenced this pull request May 15, 2015
…_assertions_enhancement

Acl assertions enhancement
weierophinney added a commit to zendframework/zend-permissions-acl that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-permissions-acl that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants