This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Additional MVC Translator BC fixes #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `__call()` implementation to proxy unknown method calls to the underlying translator instance. - Added a `getTranslator()` method to allow direct access to the underlying translator instance. - Added unit tests for the above functionality.
- Ensure MVC implementation is an i18n translator implementation - Ensure MVC implementation is a validator translator implementation
- Tested all behaviors - Added a behavior: inject the i18n TranslatorInterface service if created via the Translator::factory
|
Ping @dstockto - this PR is what will fix your issues. |
| { | ||
| public function setUp() | ||
| { | ||
| $this->i18nTranslator = $this->getMock('Zend\I18n\Translator\Translator'); |
There was a problem hiding this comment.
Shouldn't you mock the interface instead here?
There was a problem hiding this comment.
I didn't mock the interface as, later, in one of the test methods, I mock one of the method calls (setLocale).
|
Apart from the CS failues, this looks good. Approved for merging. |
ghost
assigned 
|
@weierophinney The new code did not fix the issue without code changes in the application, but putting in my service_manager config did get it to go back to working and translations are working again with no more fatal error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__callmethod)getTranslator()method to the MVC translatorZend\I18n\Translator\TranslatorInterfaceservice into the service manager if the MVC translator factory creates a new i18n Translator instance.This PR also adds unit tests for both the MVC translator and its associated factory.