This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow specifying "break chain on failure" flag as Validator option #5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When calling `attachByName()`, allow passing the "break chain on failure" flag as an option, instead of requiring it to be passed as the third argument to the method; simplifies factories. - Fixes zfcampus/zf-apigility-admin#89
| } | ||
|
|
||
| if (isset($options['breakchainonfailure'])) { | ||
| $breakChainOnFailure = (bool) $options['breakchainonfailure']; |
There was a problem hiding this comment.
Sincerely I don't like to have different ways of write the same thing. IMO this is an overhead for the framework.
Anyway, If you consider this necessary please add a test case for this option too.
There was a problem hiding this comment.
I'll add a test case -- mainly because it's documented both ways in different locations.
There was a problem hiding this comment.
For the record:
The uses of these config keys are in Zend/File/Transfer/Adapter/AbstractAdapter.php and Zend/InputFilter/Factory.php
- Wrote a data provider so that the option name both with and without underscores may be tested.
Maks3w
added a commit
that referenced
this pull request
Feb 3, 2014
Allow specifying "break chain on failure" flag as Validator option
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…y/hotfix/zf-apigility-admin-89 Allow specifying "break chain on failure" flag as Validator option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attachByName(), allow passing the "break chain on failure"flag
as an option, instead of requiring it to be passed as the third argument to
the method; simplifies factories.