This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Do not exit from loadClass() early #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In loadClass(), if the namespace/prefix matches, but the classfile is not found, we were returning a boolean false immediately. However, if a more specific namespace/prefix matches, but is later in the stack, we're essentially ignoring it, making the class unreachable. This patch removes the `return false` line in the `foreach` loop, allowing a namespace registered later to match and potentially fulfill the autoloading. There _will_ be a performance impact, which means it's always better to register the more specific namespace earlier.
| $loader = new StandardAutoloader(); | ||
| $loader->registerNamespace('ZendTest\Loader\TestAsset\Parent', __DIR__ . '/TestAsset/Parent'); | ||
| $loader->registerNamespace('ZendTest\Loader\TestAsset\Parent\Child', __DIR__ . '/TestAsset/Child'); | ||
| $loader->autoload('ZendTest\Loader\TestAsset\Parent\Child\Subclass'); |
There was a problem hiding this comment.
Can you assert on the return value? Can't really know if it was autoloaded by a different loader, no?
There was a problem hiding this comment.
The fact that no PHP errors are raised is indicative of the fact that it did not attempt to include a file it could not. However, I can likely do an assertion against !== false to validate; will update with that shortly.
|
Just to clarify here for anyone who references back to this PR later, the performance impact mentioned by @weierophinney is only applicable if you fall into this scenario where you do in fact have a more specific, overlapping namespace registered later. This is a very, very specific edge-case and unlikely to affect any current applications in practice (they would have simply ran into this bug). 😄 |
ralphschindler
pushed a commit
that referenced
this pull request
Feb 5, 2014
Merge branch 'hotfix/standard-autoloader-stack' of git://github.com/weierophinney/zf2 into weierophinney-hotfix/standard-autoloader-stack * 'hotfix/standard-autoloader-stack' of git://github.com/weierophinney/zf2: [#5783] Assertion on return value Do not exit from loadClass() early
ralphschindler
pushed a commit
that referenced
this pull request
Feb 5, 2014
Merge branch 'weierophinney-hotfix/standard-autoloader-stack' into develop * weierophinney-hotfix/standard-autoloader-stack: [#5783] Assertion on return value Do not exit from loadClass() early
weierophinney
added a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
Merge branch 'hotfix/standard-autoloader-stack' of git://github.com/weierophinney/zf2 into weierophinney-hotfix/standard-autoloader-stack * 'hotfix/standard-autoloader-stack' of git://github.com/weierophinney/zf2: [zendframework/zendframework#5783] Assertion on return value Do not exit from loadClass() early
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
Merge branch 'weierophinney-hotfix/standard-autoloader-stack' into develop * weierophinney-hotfix/standard-autoloader-stack: [zendframework/zendframework#5783] Assertion on return value Do not exit from loadClass() early
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In loadClass(), if the namespace/prefix matches, but the classfile is not
found, we were returning a boolean false immediately. However, if a more
specific namespace/prefix matches, but is later in the stack, we're
essentially ignoring it, making the class unreachable.
This patch removes the
return falseline in theforeachloop, allowing anamespace registered later to match and potentially fulfill the autoloading.
There will be a performance impact, which means it's always better to
register the more specific namespace earlier.