This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Zend\InputFilter\InputFilter] SetValidationGroup() VALIDATE_ALL not working recursively #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deploy reset validation groups recursively for "VALIDATE_ALL" * Error handling for existing recursive validation group deployment
added test for recursively resetting validation group added test for InvalidArgumentException on setting validation group on non-inputfilter
added test for recursively resetting validation group added test for InvalidArgumentException on setting validation group on non-inputfilter
|
travis build failure, you should fix the trailing_spaces. |
updated tests for recursive setValidationGroup to VALIDATE_ALL
|
updated the test, sorry for that |
removed trailing spaces
-Had my added test methods added twice. -Checked trailing spaces
|
you need to use php-cs-fixer to do that, |
ran php-cs-fixer against the test
|
What an odyssey! Hope its ok now ... |
| } | ||
|
|
||
| /** | ||
| * @expectedException Zend\InputFilter\Exception\InvalidArgumentException |
There was a problem hiding this comment.
We prefer use setExpectedException just before to call the method which should throw the exception. By this way we avoid false oks if any line before throws the same exception but for a different reason.
Moved the expected exception assertion from annotation to method body
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
[Zend\InputFilter\InputFilter] SetValidationGroup() VALIDATE_ALL not working recursively
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
- space between conditional and operator
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…ster [Zend\InputFilter\InputFilter] SetValidationGroup() VALIDATE_ALL not working recursively
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
- space between conditional and operator
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this issue:
#5819