This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed bug that didn't allow the connection to the SQLite database to be closed #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be closed when quoting a value using the Platform object
|
Can you change this PR to master? Seeing as though this is a bugfix, I wanted to get it into 2.2 |
|
Also, there seems to be some rouge files coming in: I think you mean to keep one of those but not the other? |
"rogue", not "rouge". I'm pretty sure they're not red. :) (sorry, @ralphschindler, could not resist!) |
|
Cherry-picked to master, and merged to develop. |
|
@ralphschindler I wanted to keep the tests/ZendTest/Db/Adapter/Platform/_files/ folder so the unit test could write the database file in it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #5228 for more details