This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update DateStep.php #5925
Merged
Update DateStep.php #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error: Undefined class constant 'FALSE_FORMAT'
| @@ -174,7 +174,7 @@ protected function convertString($value, $addErrors = true) | |||
| $errors = DateTime::getLastErrors(); | |||
| if ($errors['warning_count'] > 0) { | |||
| if ($addErrors) { | |||
| $this->error(self::FALSE_FORMAT); | |||
| $this->error(self::FALSEFORMAT); | |||
There was a problem hiding this comment.
It doesn't seem clear from the diffs, but is there a hidden character here (between FALSE and FORMAT)?
There was a problem hiding this comment.
Not seeing any problem myself, @Ocramius -- maybe an issue with how the diff HTML markup is generated? The diff does not show a space: https://github.com/zendframework/zf2/pull/5925.diff
There was a problem hiding this comment.
Nvm... something weird with firefox nightly and the generated HTML
DateStep extends Date and calls parent::isValid it must implement the same messageTemplates
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Update DateStep.php
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix error: Undefined class constant 'FALSE_FORMAT'
add missing template messages