Parameter generator backslash escaping

[Ocramius]

Found while trying different default parameters for methods. Currently, Zend\Code is not able to produce valid code when following is being done:

$generator = new Zend\Code\Generator\ParameterGenerator();

$generator->setType('Foo');
$generator->setDefaultValue('\\');
$generator->setName('bar');

var_dump($generator->generator());

Produces

Foo $bar = '\'

Which is obviously going to break method signature if used as a method parameter.

[Maks3w]

CS: If the use of single quotes implies escapping then use double quotes

[Maks3w]

You could write a data provider instead write unique tests for each value

[Ocramius]

CS: If the use of single quotes implies escapping then use double quotes

Hmm, always used single quotes in any possible case - is that a new one that I missed?

[Maks3w]

It's a rule of the outdate ZF CS guidelines. It's more readable a string without escaping characters.

Anyway. CS is always subject to readability.

[Maks3w]

It's needed another test in ParameterGeneratorTest