This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Dispatch error should be preventable #6024
Merged
weierophinney
merged 3 commits into
zendframework:master
from
Ocramius:hotfix/mvc-dispatch-error-should-be-preventable
Apr 14, 2014
Merged
Dispatch error should be preventable #6024
weierophinney
merged 3 commits into
zendframework:master
from
Ocramius:hotfix/mvc-dispatch-error-should-be-preventable
Apr 14, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that MVC dispatch can be restored
…ng application runtime
@weierophinney assigning you since you probably know why that early |
@@ -306,7 +306,6 @@ public function run() | |||
if ($event->getError()) { | |||
return $this->completeRequest($event); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd argue that if we're not going to return out of the parent conditional, this conditional can be removed, as it's repeated immediately below.
Honestly, I cannot quite remember. On review today, I don't see any good reason why, and clearly that use case is not covered by the tests, as your change doesn't lead to new failures. |
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
…ld-be-preventable Dispatch error should be preventable
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the tests.
It is currently impossible for a listener of
Zend\Mvc\MvcEvent::EVENT_DISPATCH_ERROR
to do following:This PR fixes that