This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Use AuthenticationServiceInterface as type #6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -48,7 +48,7 @@ public function setAuthenticationService(AuthenticationService $authenticationSe | |||
| */ | |||
| public function __invoke() | |||
| { | |||
| if (!$this->authenticationService instanceof AuthenticationService) { | |||
| if (!$this->authenticationService instanceof AuthenticationServiceInterface) { | |||
| throw new Exception\RuntimeException('No AuthenticationService instance provided'); | |||
There was a problem hiding this comment.
No AuthenticationServiceInterface instance provided 😄
|
Marked as BC break, as the API of the |
|
@Ocramius Fair enough, would that be a problem for 2.4.0? |
|
@JustInVTime no, the change is ok, but it can't land in |
Maks3w
added a commit
that referenced
this pull request
Apr 4, 2014
…terface Use AuthenticationServiceInterface as type
|
This patch should be applied to |
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…/useAuthenticationServiceInterface Use AuthenticationServiceInterface as type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.