This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
NumberOfParameterFilter correctly handles argument count greater than 0. #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ class NumberOfParameterFilter implements FilterInterface | |||
| */ | |||
| public function __construct($numberOfParameters = 0) | |||
| { | |||
| $this->numberOfParameters = 0; | |||
| $this->numberOfParameters = $numberOfParameters; | |||
|
@Ocramius Thanks for the fast reply, I just added the typecast. |
Ocramius
added a commit
that referenced
this pull request
Apr 6, 2014
|
@danfinnie thanks! |
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…-of-parameters-filter-honored' Close zendframework/zendframework#6083
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…-of-parameters-filter-honored' into develop Close zendframework/zendframework#6083 Forward Port zendframework/zendframework#6083
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NumberOfParameterFilter used to have a constructor argument for the number of parameters to filter by, but this was ignored and always set to 0. Luckily, the use case for the filter was restricting the getter, is, has, etc. filters to 0-arity functions so this was OK. This pull request fixes the class to handle any number of arguments as shown in testArityOne().