This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added map naming strategy for hydrator #6091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param array $extractMap Map for extract name converion. | ||
| * @return \Application\Stdlib\Hydrator\NamingStrategy\MapNamingStrategy | ||
| */ | ||
| public function setExtractMap($extractMap) |
There was a problem hiding this comment.
Could you avoid the setters or make them protected at least?
|
@pszczekutowicz this strategy seems to deal only with strings, right? |
|
@Ocramius you are right, it is only for strings. |
As there is no setter for maps at least one map should be required to instantiate MapNamingStrategy
|
@pszczekutowicz so this code would fail on non-string values (with notices/warnings) - can you make that part stricter or allow passing in something like an |
| * Initialize. | ||
| * | ||
| * @param array $hydrateMap | ||
| * @param array $extractMap |
There was a problem hiding this comment.
These names should map the argument names.
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
Added map naming strategy for hydrator
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
- Updated docblock parameter names to match signature; added descriptions
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
|
Merged to develop for release with 2.4.0. |
wdalmut
pushed a commit
to wdalmut/zf2
that referenced
this pull request
Apr 24, 2014
- Updated docblock parameter names to match signature; added descriptions
wdalmut
pushed a commit
to wdalmut/zf2
that referenced
this pull request
Apr 24, 2014
- Updated docblock parameter names to match signature; added descriptions
freax
pushed a commit
to freax/zf2
that referenced
this pull request
Nov 27, 2014
- Updated docblock parameter names to match signature; added descriptions
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…cz/map-naming-strategy Added map naming strategy for hydrator
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
- Updated docblock parameter names to match signature; added descriptions
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added naming strategy for hydrator that allows to translate key names from array according to given map.