This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix undefined classes, constants and methods #6094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,7 +179,7 @@ public static function removeFromAttribute(array &$data, $attribName, $value) | |||
| * @param mixed $value | |||
| * @return string|null | |||
| */ | |||
| private static function valueToLdap($value) | |||
| protected static function valueToLdap($value) | |||
There was a problem hiding this comment.
Are these methods called statically only from within the class? Because I'd simply change the static:: calls to self:: calls instead of increasing visibility
There was a problem hiding this comment.
Yes. But in my opinion these methods would be useful in possible subclasses anyway (e.g. if you want to change the conversion). Therefore I preferred the increased visibility.
There was a problem hiding this comment.
I'd personally disallow inheritance usage here unless there's a very strong use-case for it - if you don't have it, then changing static:: to self:: is preferable.
|
Pull request updated to use |
| @@ -551,7 +551,7 @@ protected function resolveAndCallInjectionMethodForInstance($instance, $method, | |||
| * @param string $method | |||
| * @param array $callTimeUserParams | |||
| * @param string $alias | |||
| * @param int|bolean $methodRequirementType | |||
| * @param int|boolean $methodRequirementType | |||
There was a problem hiding this comment.
use bool instead. see #3342
There was a problem hiding this comment.
@samsonasik handled @786757c5ab564de8d23495566ab3fbca459e45cb
|
@micheh thanks for changing the visibility as requested. I will merge as-is: if you feel like changing visibility of the discussed methods is required, then I'd still want to see a good use-case before accepting such a change ;-) |
Ocramius
added a commit
that referenced
this pull request
Apr 13, 2014
Ocramius
added a commit
that referenced
this pull request
Apr 13, 2014
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
weierophinney
pushed a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
weierophinney
pushed a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-serializer
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
gianarb
pushed a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
weierophinney
pushed a commit
to zendframework/zend-permissions-acl
that referenced
this pull request
May 15, 2015
weierophinney
pushed a commit
to zendframework/zend-permissions-acl
that referenced
this pull request
May 15, 2015
…ls-fixes' into develop Close zendframework/zendframework#6094 Forward Port zendframework/zendframework#6094
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes undefined classes in phpDoc and one undefined class constant. In addition, the visibility for some methods was increased to
protectedas those methods were called withstatic.