This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Stdlib\PriorityList fix current and iterator #6242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -231,6 +232,14 @@ public function valid() | |||
| } | |||
|
|
|||
| /** | |||
| * @return self | |||
| */ | |||
| public function getIterator() | |||
There was a problem hiding this comment.
This method is not needed unless PriorityList implements IteratorAggregate
There was a problem hiding this comment.
This is for Stdlib\PriorityQueue continuity.
Interface is not implemented because \Iterator and \IteratorAggregate is incompatible.
| */ | ||
| public function getIterator() | ||
| { | ||
| return clone $this; |
There was a problem hiding this comment.
goal of creating a class here #5702
cloning because https://github.com/zendframework/zf2/blob/cc81ee796ffaccadc0ea95debdf61d5d37cbedd9/library/Zend/Stdlib/PriorityQueue.php#L154
|
Note to self: reword commits on merge |
|
Manually merged @553e0a16ab07e49de0b46cdd8a6106e21b5b9978 |
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…List/fixCurrentAndIterator' into develop Close zendframework/zendframework#6242
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add sort before get
current()add
getIterator()which return cloned self instance