Return the text value in _ array key #6279

catalint · 2014-05-15T11:47:16Z

If element has attributes & string value until now the string value was ignored & lost, I added the _ index so that it also returns the string value along with the attribute names

See https://wiki.php.net/rfc/default_encoding > PHP 5.6 and master, introduce new php.ini setting. Old iconv.*/mbstring.* php.ini parameters will be removed for master PHP6. Use of iconv.*/mbstring.* php.ini parameters raise E_DEPRECATED for 5.6 and up.

…coding-deprecated-in-php-5.6 #6218 - applying hotfix for `iconv.internal_encoding` deprecation

Close #6219

Close #6245

Close #6238

Fixed charset support for Pdo_Pgsql.

Close #6033

Close #6184

Close #6254 Close #6188

Close #6223

If element has attributes & string value until now the string value was ignored & lost, I added the _ index so that it also returns the string value along with the attribute names

Ocramius · 2014-05-15T15:30:20Z

Needs a test case

Ocramius · 2014-05-15T15:30:35Z

library/Zend/Config/Reader/Xml.php

@@ -149,7 +149,11 @@ protected function processNextElement()

                if ($attributes) {
                    if (!is_array($child)) {
-                        $child = array();
+                        if(is_string($child)){


if (is_string($child)) {

catalint · 2014-05-17T19:08:39Z

10x @Ocramius , could you please give me some pointers where/how to start building the test-case for Travis ?

Ocramius · 2014-05-17T20:55:09Z

@catalint you can look at existing tests in https://github.com/zendframework/zf2/blob/9f4a9bc04dd711003458d6a814338d0904b0eb40/tests/ZendTest/Config/Reader/XmlTest.php

Ocramius · 2014-07-28T00:35:55Z

@catalint did you get to check the tests? You can eventually ask on IRC on channel #zftalk

catalint · 2014-07-29T11:05:09Z

yeah, found them in the repo, didn't get the change to add some for my
changes, hope I'll get this done by august's end

On Mon, Jul 28, 2014 at 3:36 AM, Marco Pivetta [email protected]
wrote:

@catalint https://github.com/catalint did you get to check the tests?
You can eventually ask on IRC on channel #zftalk

—
Reply to this email directly or view it on GitHub
#6279 (comment).

adamlundrigan · 2014-11-15T14:23:08Z

@catalint disregard my previous comment....I see it now

adamlundrigan · 2014-11-15T14:45:57Z

Added test case + CS cleanup in new PR #6879

adamlundrigan · 2014-11-15T15:17:13Z

@Ocramius this PR can be closed in favor of #6879

Ocramius · 2014-11-17T17:58:03Z

Closing as per @adamlundrigan's work. @catalint your commits will be ported, thanks! :-)

…nflict' into develop Close #6279 Close #6879 Forward port #6279 Forward port #6879

…nflict' Close #6279 Close #6879

catalint · 2014-11-18T05:15:58Z

@adamlundrigan deservs a cold beer :) thanks
On Nov 17, 2014 7:58 PM, "Marco Pivetta" [email protected] wrote:

Closing as per @adamlundrigan https://github.com/adamlundrigan's work.
@catalint https://github.com/catalint your commits will be ported,
thanks! :-)

—
Reply to this email directly or view it on GitHub
#6279 (comment).

… minor CS fixes

…endframework#6879-zend-config-reader-xml-node-value-conflict' Close zendframework/zendframework#6279 Close zendframework/zendframework#6879

…endframework#6879-zend-config-reader-xml-node-value-conflict' into develop Close zendframework/zendframework#6279 Close zendframework/zendframework#6879 Forward port zendframework/zendframework#6279 Forward port zendframework/zendframework#6879

hschletz and others added 26 commits March 24, 2014 12:52

Fixed charset support for Pdo_Pgsql.

6a41be4

Fix E_DEPRECATED message

9d16c4d

Edit test suit about deprecated using of safe option

997791d

Fixes typos

b11fca0

Merge pull request #6219 from Ocramius/hotfix/#6218-iconv-internal-en…

fc3e4c9

…coding-deprecated-in-php-5.6 #6218 - applying hotfix for `iconv.internal_encoding` deprecation

Merge branch 'hotfix/6219'

b173c71

Close #6219

Merge pull request #6237

d8158b4

Merge pull request #6237 in master

369afb5

Fix: CS of closure

3786db7

Fix invalid step error caused by DST

219fbfe

remove unused use

c4ca6e6

CS

ccfa646

#6245 - single quotes for string values without interpolation

de4539b

#6245 - adding coverage and group annotations

a08c5a5

Merge branch 'hotfix/#6245-invalid-date-step-error-with-dst'

cc81ee7

Close #6245

Fixes #6188

6d9c57f

added missing full stop

7c011a1

#6238 - PSR-2 expects one parameter per line in function calls

90cb259

Merge branch 'cs/abstract-controller-test-case-closure-braces'

8bc19d0

Close #6238

Merge pull request #6033 from hschletz/fix-db-charset-support

f30bdc6

Fixed charset support for Pdo_Pgsql.

Merge branch 'hotfix/6033'

a1085b7

Close #6033

Merge branch 'hotfix/#6184-deprecated-mongodb-flags-replacement'

0f72a6f

Close #6184

Merge branch 'doc/#6254-per-component-contributing.md'

794f8d9

Close #6254 Close #6188

Merge branch 'hotfix/#6223-soap-registration-of-complex-type'

9f4a9bc

Close #6223

Return the text value in _ array key

7077dc9

If element has attributes & string value until now the string value was ignored & lost, I added the _ index so that it also returns the string value along with the attribute names

Ocramius reviewed May 15, 2014
View reviewed changes

Ocramius added enhancement labels May 17, 2014

weierophinney added the awaiting author updates label Aug 6, 2014

EvanDotPro force-pushed the master branch from f77f90b to 21a17e5 Compare September 28, 2014 00:34

adamlundrigan added a commit to adamlundrigan/zf2 that referenced this pull request Nov 15, 2014

Reproducing test case for zendframework#6279

70a7d26

Ocramius self-assigned this Nov 17, 2014

Ocramius added this to the 2.3.4 milestone Nov 17, 2014

Ocramius added the duplicate label Nov 17, 2014

Ocramius closed this Nov 17, 2014

Ocramius added a commit that referenced this pull request Nov 17, 2014

#6279 - #6879 - minor CS fixes

116bf04

Ocramius added a commit that referenced this pull request Nov 17, 2014

Merge branch 'hotfix/#6279-#6879-zend-config-reader-xml-node-value-co…

b4f6735

…nflict' into develop Close #6279 Close #6879 Forward port #6279 Forward port #6879

Ocramius added a commit that referenced this pull request Nov 17, 2014

Merge branch 'hotfix/#6279-#6879-zend-config-reader-xml-node-value-co…

529a0c8

…nflict' Close #6279 Close #6879

Ocramius added bug and removed awaiting author updates enhancement labels Nov 17, 2014

gianarb pushed a commit to zendframework/zend-config that referenced this pull request May 15, 2015

Reproducing test case for zendframework/zendframework#6279

1ca6ca6

gianarb pushed a commit to zendframework/zend-config that referenced this pull request May 15, 2015

zendframework/zendframework#6279 - zendframework/zendframework#6879 -…

f7266d9

… minor CS fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return the text value in _ array key #6279

Return the text value in _ array key #6279

catalint commented May 15, 2014

Ocramius commented May 15, 2014

Ocramius May 15, 2014

catalint commented May 17, 2014

Ocramius commented May 17, 2014

Ocramius commented Jul 28, 2014

catalint commented Jul 29, 2014

adamlundrigan commented Nov 15, 2014

adamlundrigan commented Nov 15, 2014

adamlundrigan commented Nov 15, 2014

Ocramius commented Nov 17, 2014

catalint commented Nov 18, 2014

Return the text value in _ array key #6279

Return the text value in _ array key #6279

Conversation

catalint commented May 15, 2014

Ocramius commented May 15, 2014

Ocramius May 15, 2014

Choose a reason for hiding this comment

catalint commented May 17, 2014

Ocramius commented May 17, 2014

Ocramius commented Jul 28, 2014

catalint commented Jul 29, 2014

adamlundrigan commented Nov 15, 2014

adamlundrigan commented Nov 15, 2014

adamlundrigan commented Nov 15, 2014

Ocramius commented Nov 17, 2014

catalint commented Nov 18, 2014