This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fieldset ignore disabled elements #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-assigning to @weierophinney for review as per discussion in #6143 |
weierophinney
added a commit
that referenced
this pull request
Aug 7, 2014
Fieldset ignore disabled elements
|
This issue spawned a new bug: #6585 |
| @@ -584,7 +585,12 @@ public function bindValues(array $values = array()) | |||
| $value = $element->bindValues($value); | |||
| } | |||
|
|
|||
| $hydratableData[$name] = $value; | |||
| // skip post values for disabled elements, get old value from object | |||
| if(!$element->hasAttribute('disabled')) { | |||
There was a problem hiding this comment.
I think you should verify with getAttribute instead of hasAttribute in my case, disabled is false but already exists!
|
This also broke for me a form where I had continue_if_empty on the input set to true. I wanted to run a validator on an element composer of other elements. So I added the element, its NOT disabled and is required, but I don't want to throw the Not Empty validator error. Need to start digging for what changed and how it impacted my code. Meh... |
This was referenced Sep 27, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6143 - in my opinnion disabled elements should be automatically ignored by zf2.
I've changed Fieldset to extract the original value from the bound object and also added a unit test.