This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix Zend/Barcode composer.json to require zendframework/zend-validator. #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also explain why zendframework/zend-servicemanager is suggested. zendframework/zend-validator is needed because all barcodes are validated using Zend\Validator\Barcode prior to drawing. zendframework/zend-servicemanager is suggested because it’s needed when using the factory methods to create or render a barcode.
|
Merged, thanks! |
weierophinney
pushed a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
…rk/zf2#6293-zend-barcode-dependencies' Close zendframework/zendframework#6310 Close zendframework/zendframework#6293
weierophinney
pushed a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
…rk/zf2#6293-zend-barcode-dependencies' into develop Forward port zendframework/zendframework#6310
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #6293, make
zendframework/zend-barcoderequirezendframework/zend-validator, since barcodes are validated at draw time. We also mention whyzendframework/zend-servicemanageris suggested.I have not been able to test this yet (outside of validating the composer file), because I would first need to split Zend/Barcode into a subtree to feed it to Composer, and set-up a VM to get a recent enough version of PHP. Feel free to take it as-is or to wait until I test it.