This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Bugfix/thousand separator in number validator #6326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is pretty interesting. On the second build PHP 5.6 failed on a Zend\Cache test (so not related to this ticket), but succeeded on another run. I wonder how that test can conditionally fail without changes. |
|
I thought it was resolved in #6303 |
|
@jkavalik Apparently only works up to a specific load. |
| $validators[] = new NumberValidator(array( | ||
| 'locale' => 'en_US', // HTML5 uses "100.01" format | ||
| )); | ||
| // HTML5 always transmits values in the format "1ß00.01", without a |
There was a problem hiding this comment.
As discussed on IRC, should be 1000.01
…german keyboard layout
Ocramius
added a commit
that referenced
this pull request
Jul 28, 2014
…to develop Forward port #6326
|
Merged \o/ |
|
Note: there's a failure, but it seems unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML5 always transmits values in the format "1ß00.01", without a thousand separator. The prior use of the i18n Float validator allowed the thousand separator, which resulted in wrong numbers when casting to float.