This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Bugfix/merging inputs with allow empty #6330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an input element defines an Input with the
requiredflag set totrue, and you add your own Input on top of that with theallow_emptyflag set totrue, it won't be properly merged into the input of the element. The reason for this is that on merge thesetRequired()method is called after thesetAllowEmpty()method, which automatically setsallowEmptyto false if therequiredflag istrue. This PR fixes this by simply shifting the method calls in themerge()method around.