Fix for odd php-cs-fixer finds

[chadicus]

I do not know why php-cs-fixer reported these errors, I'm assuming some character(s) within the files themselves caused some weird tokenizing.

On a fresh clone of zend/master You will get the following errors

zf2$ ./vendor/bin/php-cs-fixer fix -v --dry-run
Loaded config from "/home/chadicus/projects/zf2/.php_cs"
   1) Zend/Cache/Storage/Adapter/MemcachedResourceManager.php (visibility)
   2) Zend/Cache/Storage/Adapter/RedisResourceManager.php (visibility)
   3) Zend/Json/Decoder.php (visibility)
   4) Zend/Di/Di.php (visibility)
   5) ZendTest/Tag/Cloud/Decorator/HtmlTagTest.php (indentation)

My solution for all of the visibility errors was to move the methods within the class files. php-cs-fixer solution was to type-hint the methods with public resulting in

protected function getClass(public $instance)
{

[localheinz]

@chadicus

For me the dry run fails with this only:

[DASPRiD]

I don't think you should fix errors which aren't any. Make an issue report against PHP-CS-Fixer, but eventually, we switch to PHPCS anyway I suppose.

[chadicus]

I was doing this so developers' builds would stop failing. The noise that these failures generates distracts from actual failures within a pull request.

[DASPRiD]

Well, then the correct approach is to get rid of the buggy php-cs-fixer ;)

[chadicus]

Started down that route after I saw @localheinz PR #6182. I added my own PR #6454

[chadicus]

Feel free to close this PR if you would rather wait until php-cs-fixer is gone

[Ocramius]

@chadicus merged, thanks!

@DASPRiD green is king, let's try to get there ;-)