Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Repeal autocomplete form attribute being boolean #6464

Conversation

marek-saji
Copy link
Contributor

@malukenho
Copy link
Member

@marek-saji please rebase this PR!

@adamlundrigan
Copy link
Contributor

@weierophinney what do you think? Is it sufficient to just treat autocomplete as a freeform string attribute? The spec is very specific about what the autocomplete attribute can contain (see link from OP)...is that something we should try to validate? Seems to me like a lot of complexity for little gain...

@Ocramius
Copy link
Member

@marek-saji I manually merged this PR into develop at a2eaf84

@Ocramius Ocramius closed this Nov 19, 2014
@adamlundrigan
Copy link
Contributor

From what I've read, this depends on what version of the HTML5 spec you're following. If you refer to the W3C's HTML5 spec (October 28th 2014) it says that autocomplete has only two values, on and off. The WHATWG spec you've linked to is a "living" HTML5 spec, which more closely aligns with W3C's HTML 5.1 working draft, both of which go into much greater detail about what is allowed and where w.r.t autocomplete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants