Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Mime Part class rewind fix #6537

Closed
wants to merge 453 commits into from
Closed

Mime Part class rewind fix #6537

wants to merge 453 commits into from

Conversation

wnowogrodzki
Copy link
Contributor

Without that fix we get:

Warning: rewind(): stream does not support seeking in (...)/vendor/zendframework/zendframework/library/Zend/Mime/Part.php on line 134

Ocramius and others added 30 commits May 3, 2014 02:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ecked too
…r-optimization

Classmethod hydrator optimization - massive cleanup and extension by @Ocramius
@Ocramius
Copy link
Member

Needs a rebase as well, closing for now.

@Ocramius Ocramius closed this Oct 13, 2014
@Ocramius Ocramius self-assigned this Oct 13, 2014
@Ocramius
Copy link
Member

Actually: re-opening, as the rebase should only affect the last commit ( wnowogrodzki/zf2@47f46dbb8f151831745234cce25c8736fad71b48 )

@Ocramius Ocramius reopened this Oct 13, 2014
@wnowogrodzki
Copy link
Contributor Author

Need some help... What I really need to do to rebase this branch to work/apply this patch (and future tests) on most recent develop version... Thanks for help in advance.

@wnowogrodzki
Copy link
Contributor Author

I bet I did something wrong...

@adamlundrigan
Copy link
Contributor

@wnowogrodzki your pull request will need to be rebased against master. IMO the easiest way to do that would be to create a new local branch off master and cherry-pick your commit ( wnowogrodzki/zf2@47f46db) into it, then do a force-push to the branch on your GitHub fork used to create this pull request.

## Remotes: "origin" is your fork; "upstream" is zendframework/zf2
git checkout master
git checkout -b zf6537 upstream/master
git cherry-pick 47f46db
git push origin mime-part-rewind-fix --force
``

@Ocramius Ocramius added this to the 2.3.4 milestone Nov 19, 2014
@Ocramius
Copy link
Member

I'll have to merge this without tests, as it is not possible to influence the results of stream_get_meta_data() from userland stream wrappers

Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius Ocramius closed this in e83c2ce Nov 19, 2014
Ocramius added a commit that referenced this pull request Nov 19, 2014
@Ocramius
Copy link
Member

@wnowogrodzki merged, thanks!

master: e83c2ce
develop: 0ad4f2e

gianarb pushed a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@wnowogrodzki wnowogrodzki deleted the mime-part-rewind-fix branch September 20, 2024 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet