Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Db order expressioninterface #6722

Conversation

Pittiplatsch
Copy link

PR for #6719

Lars Heber added 5 commits October 1, 2014 14:43
…ionInterface

instead of Expression
* Add unit test for ordering using ExpressionInterface
* Improve existing unit test for ordering using Expression - the
original test actually tested expression functionality, not order
functionality
@turrsis
Copy link
Contributor

turrsis commented Nov 19, 2014

May be fix this for Select::quantifier() method too?

@Pittiplatsch
Copy link
Author

If you could provide unit tests, extending quantifier()'s API should be trivial 👍

@turrsis
Copy link
Contributor

turrsis commented Nov 19, 2014

    public function testQuantifierParameter()
    {
        $expr = $this->getMock('Zend\Db\Sql\ExpressionInterface');
        $select = new Select;
        $select->quantifier($expr);
        $this->assertSame(
            $expr,
            $select->getRawState(Select::QUANTIFIER)
        );
    }

@Ocramius Ocramius self-assigned this Dec 11, 2014
@Ocramius Ocramius modified the milestones: 2.4.0, 2.3.4 Dec 11, 2014
@Ocramius Ocramius closed this in 530fab5 Dec 16, 2014
Ocramius added a commit that referenced this pull request Dec 16, 2014
@Ocramius
Copy link
Member

@Pittiplatsch merged, thanks!

master: 530fab5
develop: 088c2ee

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants