This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Incompatible with RecursiveIterator #6825
Closed
noopable
wants to merge
5
commits into
zendframework:master
from
noopable:issue/4517/Incompatible_with_RecursiveIterator
Closed
Incompatible with RecursiveIterator #6825
noopable
wants to merge
5
commits into
zendframework:master
from
noopable:issue/4517/Incompatible_with_RecursiveIterator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*/ | ||
protected $logger; | ||
|
||
public function setLogger($logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use Type hiting here setLogger(ArrayObject $logger)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log may just be a public property if this is only a test asset
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…s for newly introduced tests
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…-recursive-iterator-compatibility' Close zendframework/zendframework#6825 Close zendframework/zendframework#4517
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…-recursive-iterator-compatibility' into develop Close zendframework/zendframework#6825 Close zendframework/zendframework#4517 Forward port zendframework/zendframework#6825 Forward port zendframework/zendframework#4517
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4517
http://php.net/manual/en/recursiveiterator.haschildren.php