Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Incompatible with RecursiveIterator #6825

Conversation

noopable
Copy link
Contributor

@noopable noopable commented Nov 1, 2014

#4517

http://php.net/manual/en/recursiveiterator.haschildren.php

Returns TRUE if the current entry can be iterated over, otherwise returns FALSE.

*/
protected $logger;

public function setLogger($logger)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Type hiting here setLogger(ArrayObject $logger)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log may just be a public property if this is only a test asset

@Ocramius Ocramius self-assigned this Nov 22, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Nov 22, 2014
@Ocramius Ocramius closed this in 6e8a0d8 Nov 22, 2014
Ocramius added a commit that referenced this pull request Nov 22, 2014
…bility' into develop

Close #6825
Close #4517
Forward port #6825
Forward port #4517
@Ocramius
Copy link
Member

@noopable merged, thanks!

master: 6e8a0d8
develop: 0a7ce95

gianarb pushed a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants