Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

allow use differents Adapter for build SqlObjects via Db\Sql (v2) #6890

Closed
wants to merge 1 commit into from
Closed

allow use differents Adapter for build SqlObjects via Db\Sql (v2) #6890

wants to merge 1 commit into from

Conversation

turrsis
Copy link
Contributor

@turrsis turrsis commented Nov 18, 2014

allow use differents Adapter for build SqlObjects via Db\Sql
this is the reworked of #6329

@turrsis
Copy link
Contributor Author

turrsis commented Nov 18, 2014

@Ocramius I fix BC, can you merge it?

@turrsis turrsis changed the title allow use differents Adapter for build SqlObjects via Db\Sql allow use differents Adapter for build SqlObjects via Db\Sql (v2) Nov 18, 2014
@Ocramius
Copy link
Member

@turrsis it's still queued, but I'll indeed review it again as soon as I can.

@Ocramius Ocramius self-assigned this Nov 18, 2014
@Ocramius Ocramius added this to the 2.4.0 milestone Nov 18, 2014
@turrsis
Copy link
Contributor Author

turrsis commented Nov 19, 2014

Rebased and combine to one commit bacause #6885 already merged

Ocramius added a commit that referenced this pull request Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
…n't set a default platform internally at initialization time
Ocramius added a commit that referenced this pull request Nov 23, 2014
…et a default platform internally at initialization time
Ocramius added a commit that referenced this pull request Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
@Ocramius
Copy link
Member

Still adding BC break because subclasses now need to set defaultPlatform at object initialization.

Merged into develop at c91bd9b, thanks!

@Ocramius Ocramius closed this Nov 23, 2014
@turrsis turrsis mentioned this pull request Nov 25, 2014
Ocramius added a commit that referenced this pull request Nov 25, 2014
Ocramius added a commit that referenced this pull request Nov 25, 2014
@Ocramius Ocramius removed the BC Break label Nov 25, 2014
@Ocramius
Copy link
Member

Reverting BC Break label as the breakage was fixed by #6924

@turrsis turrsis deleted the db/sql/fix-UseOfDifferentAdapters2 branch December 3, 2014 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants