fix BC for #6890 #6924
fix BC for #6890 #6924
Conversation
| @@ -10,6 +10,12 @@ | |||
| namespace Zend\Db\Sql\Platform; | |||
|
|
|||
| use Zend\Db\Adapter\AdapterInterface; | |||
| use Zend\Db\Adapter\Platform\PlatformInterface; | |||
|
|
|||
|
Who can say why tests is failed? |
|
it's cs, there is travis build error :
You can fix with php-cs-fixer :
php-cs-fixer fix tests/ZendTest/Db/Sql/Platform/PlatformTest.php --fixers=braces
|
|
|
||
| $mockDriver = $this->getMock('Zend\Db\Adapter\Driver\DriverInterface'); | ||
| $mockDriver->expects($this->any())->method('formatParameterName')->will($this->returnValue('?')); | ||
| $mockDriver->expects($this->any())->method('createStatement')->will($this->returnCallback(function () {return new Adapter\StatementContainer;})); |
There was a problem hiding this comment.
actually here, psr-2 for closure : https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#6-closures
There was a problem hiding this comment.
the easiest way is to use php-cs-fixer :
php-cs-fixer fix tests/ZendTest/Db/Sql/Platform/PlatformTest.php --fixers=braces
|
@samsonasik Thank you! Problem was with new parameters, but with old version of |
| return $decorator; | ||
| } | ||
| foreach ($this->decorators as $type => $decorator) { | ||
| if ($subject instanceof $type && is_a($decorator, $type, true)) { |
There was a problem hiding this comment.
I don't remember - it was a long time ago.
This does not necessary and can be replaced to instanceof.
Do this?
There was a problem hiding this comment.
@turrsis instanceof is sufficient: I'll fix on merge.
This is reorganize of #6890 and c91bd9b.
Because
defaultPlatformis realy BC and don't required inZend\Db\Sql\Platform\*classes