Added consts for left and right outer joins #6931
Conversation
Currently you have to pass string and manually specify the join type if it's not included in constants.
|
Thanks 👍 Any chance you could add docblocks for all public methods that don't have them ? |
| const JOIN_RIGHT_OUTER = 'outer right'; | ||
| const JOIN_LEFT_OUTER = 'outer left'; | ||
| const JOIN_RIGHT_INNER = 'inner right'; | ||
| const JOIN_LEFT_INNER = 'inner left'; |
There was a problem hiding this comment.
AFAIK there are no left / right INNER joins? Right / left joins are specific outer joins.
Therefore, JOIN_LEFT_INNER / JOIN_RIGHT_INNER aren't meaningful while JOIN_LEFT_OUTER and JOIN_RIGHT_OUTER MIGHT be acceptable for commonly used, already existing JOIN_LEFT / JOIN_RIGHT.
There was a problem hiding this comment.
Not to be pedantic, but... considering the actual word order, shouldn't these be:
JOIN_OUTER_RIGHTJOIN_INNER_LEFT- etc.
? Right now, the constant names do not mirror the actual usage, which could be confusing, particularly if you were to use the constant value elsewhere.
Additionally removed unnecessary inner joins constants
|
Names rearranged :) also I have removed those inners mentioned by @Pittiplatsch |
AGmakonts
changed the title
Added consts for left and right outer joins
|
Merged to develop for release in 2.4. |
Currently you have to pass string and manually specify the join type if it's not included in constants.