-
Notifications
You must be signed in to change notification settings - Fork 2.5k
CS: In method arguments and method call, there MUST NOT be a space before each comma and there MUST be one space after each comma. #7029
Conversation
@@ -472,7 +472,7 @@ public static function escapeValue($values = array()) | |||
foreach ($values as $key => $val) { | |||
// Escaping of filter meta characters | |||
$val = str_replace( | |||
array('\\', ',', '+', '"', '<', '>', ';', '#', '=',), | |||
array('\\', ',', '+', '"', '<', '>', ';', '#', '=', ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These automated fixes seem wrong: the ending comma should be removed instead, as it's the last item in an in-line defined array
: should I report this on the fixer issue tracker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP CS Fixer is build in extra atomic way. One fixer should not do multiple things.
What you are talking about is different CS issue - not done by the fixer we use in this PR.
What are you talking about is done by different fixer - single_array_no_trailing_comma
. So no, do not report issue because this isn't one. I just don't want to run all fixers at once to not produce extra large diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in that one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enuff on the explanation :-)
@Ocramius |
@keradus I'd actually defer this to the discussion in #6182 While we had our decent amount of pain with the fixer previously, I must say that the new AST(ish)-based parsing/reassembling fixed the problems it had before, so I'm quite satisfied with what is happening here. I'd still suggest you to comment there and raise your voice: since you have been this helpful and supportive here I don't see why we should move away from the tool if you keep being like this :-) |
Tool is great and I want to better integrate it with ZF2. Just don't want to waste time if you choose to stop using it. |
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
…ument-list-comma' into develop Close zendframework/zendframework#7029
No description provided.