This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
#6414-Add a condition for captcha element #7030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires a new test anyway: nothing gets merged without tests :-\ |
|
Well, the test failed on Travis while it was good on my computer. I'm goin' to check that. |
| { | ||
| $captcha = Captcha::factory(array( | ||
| 'class' => 'dumb' | ||
| )); |
There was a problem hiding this comment.
Tests also failed because of CS issues
|
The test passed on PHP 5.4/5.5/5.6. And partially executed on HHVM because of "Nesting level too deep". |
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a condition when the element is a Captcha. This way, no more validator errors. Just reCaptcha trigger an error validation about the usage of frameborder attribute in iframe tag, but it is reCaptcha related. Not zf2 responsibility.
I didn't write any tests, given the fact it is related to html validation. But I run the usual tests, and nothing goes wrong.
I hope I didn't messed up everything, since it is my first PR.
Tell me if something wrong.
Thanks.
Julien.