This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
CS: PHP keywords MUST be in lower case #7053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,7 +300,7 @@ public function testGetTypes() | |||
|
|
|||
| $count = 0; | |||
| foreach ($typesArray as $element) { | |||
| if (strpos($element, 'struct AutoDiscoverTestClass1') === 0 OR strpos($element, 'AutoDiscoverTestClass1 ArrayOfAutoDiscoverTestClass1') === 0) { | |||
| if (strpos($element, 'struct AutoDiscoverTestClass1') === 0 or strpos($element, 'AutoDiscoverTestClass1 ArrayOfAutoDiscoverTestClass1') === 0) { | |||
There was a problem hiding this comment.
Just like before, fixers are atomic ;)
There was a problem hiding this comment.
what do you think @Ocramius ?
wanna keep this PR atomic and change only one rule at once?
|
Should I do sth else in this PR ? |
|
@keradus no, seems fine, though I'll merge manually later on |
Ocramius
added a commit
that referenced
this pull request
Dec 31, 2014
CS: PHP keywords MUST be in lower case
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…rcase_keywords CS: PHP keywords MUST be in lower case
gianarb
pushed a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…rcase_keywords CS: PHP keywords MUST be in lower case
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…rcase_keywords CS: PHP keywords MUST be in lower case
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…rcase_keywords CS: PHP keywords MUST be in lower case
gianarb
pushed a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
…rcase_keywords CS: PHP keywords MUST be in lower case
weierophinney
pushed a commit
to zendframework/zend-i18n-resources
that referenced
this pull request
May 28, 2015
…rcase_keywords CS: PHP keywords MUST be in lower case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.