Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Travis - show PHP CS Fixer diff #7057

Merged
merged 1 commit into from
Dec 31, 2014
Merged

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Dec 18, 2014

No description provided.

@Ocramius Ocramius self-assigned this Dec 18, 2014
@Ocramius Ocramius added this to the 2.4.0 milestone Dec 18, 2014
@Ocramius
Copy link
Member

Fixes #7054

@keradus
Copy link
Contributor Author

keradus commented Dec 18, 2014

wow, you are faster than me ;)
need to see how will it works under parallel

@Ocramius
Copy link
Member

need to see how will it works under parallel

Should be the same: parallel keeps the right order, but it may swallow some special chars

@keradus
Copy link
Contributor Author

keradus commented Dec 18, 2014

@keradus
Copy link
Contributor Author

keradus commented Dec 18, 2014

Then - ready ;)

@Ocramius
Copy link
Member

@keradus this looks horribly broken: https://travis-ci.org/zendframework/zf2/jobs/44507815#L1292

@keradus
Copy link
Contributor Author

keradus commented Dec 18, 2014

@Ocramius yeah, it is already fixed and merged 7 days ago into 1.4@dev : PHP-CS-Fixer/PHP-CS-Fixer#821

@Ocramius
Copy link
Member

@keradus we probably need to change composer.json to point at the friends-of-php repo: can you try factoring in the PR? Is it possible to have a stable version tagged with the patch?

@keradus
Copy link
Contributor Author

keradus commented Dec 19, 2014

@Ocramius

It is pointing FriendsOfPHP repo, originally it was Fabien's project, it was moved into FriendsOfPHP but without chanign composer package name for keeping BC, it is already planned to do at 2.0 line, which is currently under development.

1.4 stable is in action (release isn't only new tag for PHP CS Fixer), please wait a while.

Ocramius added a commit that referenced this pull request Dec 31, 2014
Travis - show PHP CS Fixer diff
@Ocramius Ocramius merged commit bdef389 into zendframework:develop Dec 31, 2014
@Ocramius
Copy link
Member

@keradus thanks!

@keradus keradus deleted the travis branch January 1, 2015 18:54
weierophinney pushed a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants